feat(taxonomy): added view/create/updated taxonomy field support #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerGauntlett
changed the title
TylerGauntlett
changed the title
tjuanitas
approved these changes
Oct 18, 2024
tjuanitas
reviewed
Oct 18, 2024
| this.errorCode = ERROR_CODE_FETCH_METADATA; | ||
| const baseUrl = this.getMetadataUrl(id); | ||
| const url = isMetadataRedesign ? `${baseUrl}?view=hydrated` : baseUrl; |
There was a problem hiding this comment.
nit: there are some patterns in this file which use a separate function to build the URLs
There was a problem hiding this comment.
We have some taxonomy node related API code in progress. I'll look to use some of these patterns as part of that work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demos: